Skip to content

[comms, commsdsl] update ports#16415

Merged
BillyONeal merged 12 commits intomicrosoft:masterfrom
mathisloge:comms
Apr 29, 2021
Merged

[comms, commsdsl] update ports#16415
BillyONeal merged 12 commits intomicrosoft:masterfrom
mathisloge:comms

Conversation

@mathisloge
Copy link
Contributor

@mathisloge mathisloge commented Feb 25, 2021

Describe the pull request

  • Update comms and commsdsl to the next version

  • Which triplets are supported/not supported? Have you updated the CI baseline?yes

  • Does your PR follow the maintainer guide?yes

@mathisloge
Copy link
Contributor Author

mathisloge commented Feb 25, 2021

build failures for static builds maybe related to #15390 ?

@JonLiu1993 JonLiu1993 self-assigned this Feb 26, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 26, 2021
@JonLiu1993
Copy link
Contributor

JonLiu1993 commented Feb 26, 2021

Hi @mathisloge ,Thanks for your PR.
Can you run the command ./vcpkg x-add-version --all --overwrite-version on your local, and then resubmit it? I try to help you modify but I don't have permission to push

@JonLiu1993
Copy link
Contributor

JonLiu1993 commented Mar 2, 2021

@mathisloge ，Please take a look at this：
install-x64-windows-static-dbg-out.log

@mathisloge
Copy link
Contributor Author

mathisloge commented Mar 3, 2021

build failures for static builds maybe related to #15390 ?

@JonLiu1993 i think it might be related to the mentioned PR.

Since the changes introduced with this PR doesn't change the code related to xml or cmake and the previous version has been build successfully.

@JonLiu1993
Copy link
Contributor

JonLiu1993 commented Mar 3, 2021

@mathisloge ，I agree with you, we can wait for the pr merge and re-run CI

@mathisloge
Copy link
Contributor Author

mathisloge commented Apr 27, 2021

@JonLiu1993 there was indeed a change in upstream cmake. needed to build only with dynamic linking.
this is ready to review and merge. the CI failures are not related to this PR (but to this #17528)

JonLiu1993
JonLiu1993 reviewed Apr 28, 2021
View reviewed changes
JonLiu1993
JonLiu1993 reviewed Apr 28, 2021
View reviewed changes
JonLiu1993
JonLiu1993 reviewed Apr 28, 2021
View reviewed changes
JonLiu1993
JonLiu1993 reviewed Apr 28, 2021
View reviewed changes
@JonLiu1993
Copy link
Contributor

JonLiu1993 commented Apr 28, 2021

@mathisloge, please modify the part suggested above, and then we can merge this pr after waiting for the basline pr to be merged

@mathisloge
Copy link
Contributor Author

mathisloge commented Apr 28, 2021 •
edited
Loading

@JonLiu1993
have changed it to version-semver
https://github.com/commschamp/commsdsl#versioning

@mathisloge
Copy link
Contributor Author

mathisloge commented Apr 28, 2021

@JonLiu1993 merged master after #17528 was merged and now CI is good

@JonLiu1993 JonLiu1993 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Apr 29, 2021
@BillyONeal BillyONeal merged commit 387623e into microsoft:master Apr 29, 2021
@BillyONeal
Copy link
Member

BillyONeal commented Apr 29, 2021

Thanks for your contribution!

@mathisloge mathisloge deleted the comms branch April 29, 2021 21:02
@mathisloge mathisloge mentioned this pull request Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JonLiu1993 JonLiu1993 JonLiu1993 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JonLiu1993 JonLiu1993

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mathisloge @JonLiu1993 @BillyONeal